Move test support to root of model_signing. #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we will need to share some of the models with other directories besides serialization, the only way to achieve this without duplication is to have `conftest.py` in the root testing directory. And, when moving that, we also need to move `test_support.py` which defines useful constants used both in tests and in `conftest.py`. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
spencerschrock
approved these changes
Jul 24, 2024
susperius
pushed a commit
to susperius/model-transparency
that referenced
this pull request
Jul 24, 2024
Since we will need to share some of the models with other directories besides serialization, the only way to achieve this without duplication is to have `conftest.py` in the root testing directory. And, when moving that, we also need to move `test_support.py` which defines useful constants used both in tests and in `conftest.py`. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com> Signed-off-by: Martin Sablotny <msablotny@nvidia.com>
susperius
pushed a commit
to susperius/model-transparency
that referenced
this pull request
Jul 24, 2024
Since we will need to share some of the models with other directories besides serialization, the only way to achieve this without duplication is to have `conftest.py` in the root testing directory. And, when moving that, we also need to move `test_support.py` which defines useful constants used both in tests and in `conftest.py`. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since we will need to share some of the models with other directories besides serialization, the only way to achieve this without duplication is to have
conftest.pyin the root testing directory. And, when moving that, we also need to movetest_support.pywhich defines useful constants used both in tests and inconftest.py.Release Note
NONE
Documentation
NONE