Fixing lint issues in the signature package #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Sablotny <msablotny@nvidia.com>
Signed-off-by: Martin Sablotny <msablotny@nvidia.com>
susperius
force-pushed
the
fix/signature-lints
branch
3 times, most recently
from
4289cf8
to
31008b9
Compare
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Martin Sablotny <msablotny@nvidia.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
mihaimaruseac
approved these changes
Jul 25, 2024
|
Oh, it seems trying to speed up merging by committing code suggestions actually makes it so that my review doesn't count for merging. Let's wait for @spencerschrock or @laurentsimon for one more review for merging this. Sorry for the delay. |
spencerschrock
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing pylint and pytype issues in the signature package
Release Note
None
Documentation
None