-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing lint issues in the signature package #254
Conversation
Signed-off-by: Martin Sablotny <msablotny@nvidia.com>
Signed-off-by: Martin Sablotny <msablotny@nvidia.com>
4289cf8
to
31008b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This LGTM.
Added a few nits to simplify work later when we add more CI support.
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Martin Sablotny <msablotny@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Signed-off-by: Mihai Maruseac <mihai.maruseac@gmail.com>
Oh, it seems trying to speed up merging by committing code suggestions actually makes it so that my review doesn't count for merging. Let's wait for @spencerschrock or @laurentsimon for one more review for merging this. Sorry for the delay. |
Summary
Fixing pylint and pytype issues in the signature package
Release Note
None
Documentation
None