Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Unit tests for serialize_v1 for folders #67

Merged
merged 12 commits into from
Nov 1, 2023
Merged

feat: Unit tests for serialize_v1 for folders #67

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
212330e
Uni tests for serialize_v1 for folders
laurentsimon Nov 1, 2023
c838484
typo + add sanity checks
laurentsimon Nov 1, 2023
5c12ffd
remove TODOs
laurentsimon Nov 1, 2023
a4e1a1e
remove debug print
laurentsimon Nov 1, 2023
d9dc046
use sets to simply sanity cekc assertion
laurentsimon Nov 1, 2023
c797b52
update
laurentsimon Nov 1, 2023
b1764e9
rename file and folder names
laurentsimon Nov 1, 2023
3ec77fd
missing testdata
laurentsimon Nov 1, 2023
203d058
add TODO in workflow
laurentsimon Nov 1, 2023
4ec5860
Update model_signing/serialize_test.py
laurentsimon Nov 1, 2023
e433a0a
Update model_signing/serialize_test.py
laurentsimon Nov 1, 2023
b256f29
chunk typo
laurentsimon Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion model_signing/serialize_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def test_folder_symlink_root(self):
cleanup_model(model)

# symlink in non-root folder raises ValueError exception.
def test_foler_symlink_nonroot(self):
def test_folder_symlink_nonroot(self):
model = create_empty_folder("with_nonroot_symlinks")
sub_folder = model.joinpath("sub")
create_empty_folder(str(sub_folder))
Expand Down Expand Up @@ -260,6 +260,12 @@ def test_different_ignored_paths(self):
assert (r0 != r2)
assert (r0 != r3)
assert (r0 != r4)
assert (r1 != r2)
assert (r1 != r3)
assert (r1 != r4)
assert (r2 != r3)
assert (r2 != r4)
assert (r3 != r4)

# Rename the file under dir1.
new_file = model.joinpath("dir1/f11_altered")
Expand Down Expand Up @@ -621,6 +627,12 @@ def test_different_ignored_paths(self):
assert (r0 != r2)
assert (r0 != r3)
assert (r0 != r4)
assert (r1 != r2)
assert (r1 != r3)
assert (r1 != r4)
assert (r2 != r3)
assert (r2 != r4)
assert (r3 != r4)
laurentsimon marked this conversation as resolved.
Show resolved Hide resolved

# Rename the file under dir1.
new_file = model.joinpath("dir1/f11_altered")
Expand Down
Loading