Make SLSA 4 ML workflow also run on PRs. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we'll prevent cases when this breaks on other PRs. Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac
requested review from
smeiklej,
haydentherapper and
laurentsimon
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
laurentsimon
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we'll prevent cases when this breaks on other PRs (#87, #88, #79).
Needed to select a default model, picked the one that seems to be the fastest. If we want, in the future we can extend this one to also run some e2e verification for this workflow.
There is some duplication with the default model, but short of creating a new job and working with inputs/outputs this is the best alternative I know.