-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the dependency pinning action create a PR #99
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This is an issue with the CLA for the bot, but since the "contribution" in the second commit is just automatically generated I think we can override the CLA check for the bot |
Can you override a CLA check? I thought that was set by the org. There might be an org-level bot we could use to create those commits that's approved for the CLA? Have to check with OSPO |
We can as Googlers, it's an escape hatch for the cases not covered by the bot (was using that multiple times in TF) |
Makes sense. This is a manual override, yea? You could also use one of the codeowners' PATs. |
Yeah, it's manual. I'll send the link to the page offline. We could try and force the bot to act as one codeowner and use a PAT in that case. |
One concern is that the PAT couldn’t be scoped to a specific set of files. Just thinking about mitigating a risk of the PAT being compromised. If I’m overly complicating this, I’m also good with this approach. :) |
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
re: PAT. Would fine-grained PATs help? |
I think the issue we landed on is that GHA is the author of the PR and the CLA check Google has requires CLA approval/bypass for it. So even if we use PATs, we'd still the same issue. PATs would help in making this PR be created when there's another PR that changes dependencies, but we'll still have the CLA issue |
The dependencies have been properly updated this time (in #96 because I had 3 different archives with the same set of files, only one OS had deps properly updates).
I tested that the action runs ok if there's no need to create a PR. Also runs ok on both trigger and cron.
Added the dependencies as updated by the action