Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dependency pinning action create a PR #99

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Make the dependency pinning action create a PR #99

merged 2 commits into from
Jan 11, 2024

Conversation

mihaimaruseac
Copy link
Collaborator

The dependencies have been properly updated this time (in #96 because I had 3 different archives with the same set of files, only one OS had deps properly updates).

I tested that the action runs ok if there's no need to create a PR. Also runs ok on both trigger and cron.

Added the dependencies as updated by the action

Copy link

google-cla bot commented Jan 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mihaimaruseac
Copy link
Collaborator Author

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

This is an issue with the CLA for the bot, but since the "contribution" in the second commit is just automatically generated I think we can override the CLA check for the bot

@haydentherapper
Copy link
Collaborator

Can you override a CLA check? I thought that was set by the org. There might be an org-level bot we could use to create those commits that's approved for the CLA? Have to check with OSPO

@mihaimaruseac
Copy link
Collaborator Author

We can as Googlers, it's an escape hatch for the cases not covered by the bot (was using that multiple times in TF)

@haydentherapper
Copy link
Collaborator

Makes sense. This is a manual override, yea? You could also use one of the codeowners' PATs.

@mihaimaruseac
Copy link
Collaborator Author

Yeah, it's manual. I'll send the link to the page offline.

We could try and force the bot to act as one codeowner and use a PAT in that case.

@haydentherapper
Copy link
Collaborator

One concern is that the PAT couldn’t be scoped to a specific set of files. Just thinking about mitigating a risk of the PAT being compromised.

If I’m overly complicating this, I’m also good with this approach. :)

Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
Signed-off-by: Mihai Maruseac <mihaimaruseac@google.com>
@mihaimaruseac mihaimaruseac changed the title Make the dependency pinning action create a PR and update all dependencies Make the dependency pinning action create a PR Jan 11, 2024
@mihaimaruseac mihaimaruseac merged commit c074ee6 into sigstore:main Jan 11, 2024
12 checks passed
@laurentsimon
Copy link
Collaborator

re: PAT. Would fine-grained PATs help?

@mihaimaruseac
Copy link
Collaborator Author

mihaimaruseac commented Jan 11, 2024

I think the issue we landed on is that GHA is the author of the PR and the CLA check Google has requires CLA approval/bypass for it. So even if we use PATs, we'd still the same issue.

PATs would help in making this PR be created when there's another PR that changes dependencies, but we'll still have the CLA issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants