Control the policy controller monitoring resources from chart, enhanc… #1687
Conversation
Signed-off-by: Cody Soyland <codysoyland@github.com> Signed-off-by: Senan Zedan (EXT-Nokia) <senan.zedan.ext@nokia.com>
…store#1683) Bumps [google-github-actions/auth](https://github.com/google-github-actions/auth) from 2.1.6 to 2.1.7. - [Release notes](https://github.com/google-github-actions/auth/releases) - [Changelog](https://github.com/google-github-actions/auth/blob/main/CHANGELOG.md) - [Commits](google-github-actions/auth@8254fb7...6fc4af4) --- updated-dependencies: - dependency-name: google-github-actions/auth dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Senan Zedan (EXT-Nokia) <senan.zedan.ext@nokia.com>
…ment for the current implmentation to hadd all the resources by default, The new change add avail to pass resourcesNames through the chart with list of resources comma sperataed for which resources to be monitored by the policy controller, the default is all resources if the flag wasn't presented in the chart Signed-off-by: Senan Zedan (EXT-Nokia) <senan.zedan.ext@nokia.com>
|
@vaikas - Could you please look into this? |
|
Could you add some tests, maybe here: https://github.com/sigstore/policy-controller/tree/main/test |
|
@vaikas - per your request, test added. |
That does not really test any of this new code. You'd have to add a test that launches policy controller with these new flags, here's one example where we change the policy-controller behaviour by the flags: So, create a new kustomize file that launches policy controller with say --resource-name=pods, and customize it like here: And then after the policy-controller has been started with the flags under test, you'd run your new test: It should at the bare minimum have a negative test and a positive test. So, if you're using resource-name pods, then launching a deployment with a failing config should succeed if you instead launch a pod. |
…ment for the current implmentation to hadd all the resources by default, The new change add avail to pass resourcesNames through the chart with list of resources comma sperataed for which resources to be monitored by the policy controller, the default is all resources if the flag wasn't presented in the chart
This PR resolves #1388
Signed-off-by: Senan Zedan (EXT-Nokia) senan.zedan.ext@nokia.com
Summary
The new change add avail to pass resourcesNames through the chart with list of resources comma sperataed for which resources to be monitored by the policy controller, the default is all resources if the flag wasn't presented in the chart