Add support for local registry use to the local-dev tooling #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
=======================================
Coverage 54.66% 54.66%
=======================================
Files 44 44
Lines 4831 4831
=======================================
Hits 2641 2641
Misses 1975 1975
Partials 215 215 |
Signed-off-by: Meredith Lancaster <malancas@github.com>
malancas
changed the title
hectorj2f
reviewed
Jul 14, 2023
hectorj2f
reviewed
Jul 14, 2023
hectorj2f
reviewed
Jul 14, 2023
hack/local-dev.sh
Outdated
|
|
||
| for i in ${CONFIG_FILES[@]} | ||
| do | ||
| ko apply -f $i |
There was a problem hiding this comment.
Why don't you run make ko-apply instead ?
Signed-off-by: Meredith Lancaster <malancas@github.com>
cpanato
reviewed
Jul 16, 2023
|
I am okay with any approach as long as it is easy to mantain in a longer term.i don't have strong preferences here. |
|
Thanks for the feedback, I was able to implement more with the Go CLI. I'll push an update soon that includes it. |
|
cool! |
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
malancas
changed the title
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
Signed-off-by: Meredith Lancaster <malancas@github.com>
hectorj2f
reviewed
Jul 18, 2023
hectorj2f
reviewed
Jul 18, 2023
hectorj2f
approved these changes
Jul 24, 2023
|
thanks for the review @hectorj2f, would you mind merging the PR? I don't have access to merge it |
cpanato
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for using the local Kind registry. This pull request also adds a new
k8s-versionflag. If supplied, this option determines which Kind image is used when creating the Kind cluster.cc @hectorj2f @vaikas
Release Note
Documentation