Skip to content

Merge pull request #43 from siketyan/dependabot/cargo/openssl-0.10.66 #110

Merge pull request #43 from siketyan/dependabot/cargo/openssl-0.10.66

Merge pull request #43 from siketyan/dependabot/cargo/openssl-0.10.66 #110

GitHub Actions / clippy succeeded Jul 22, 2024 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 89 in app/src/plugin.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`extern` fn uses type `dyn autoclip_core::PluginRegistrar`, which is not FFI-safe

warning: `extern` fn uses type `dyn autoclip_core::PluginRegistrar`, which is not FFI-safe
  --> app/src/plugin.rs:89:19
   |
89 |         function: unsafe extern "C" fn(&mut dyn autoclip_core::PluginRegistrar) -> (),
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
   |
   = note: trait objects have no C equivalent
   = note: `#[warn(improper_ctypes_definitions)]` on by default

Check warning on line 103 in app/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> app/src/main.rs:103:9
    |
103 |         previous = contents.clone();
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `previous.clone_from(&contents)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
    = note: `#[warn(clippy::assigning_clones)]` on by default

Check warning on line 57 in app/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

writing `&PathBuf` instead of `&Path` involves a new object where a slice will do

warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
  --> app/src/main.rs:57:19
   |
57 |     plugins_path: &PathBuf,
   |                   ^^^^^^^^ help: change this to: `&Path`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
   = note: `#[warn(clippy::ptr_arg)]` on by default

Check warning on line 14 in app/src/platform/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

trait `GetClipboardTypes` is never used

warning: trait `GetClipboardTypes` is never used
  --> app/src/platform/mod.rs:14:18
   |
14 | pub(crate) trait GetClipboardTypes {
   |                  ^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 26 in core/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`extern` fn uses type `dyn PluginRegistrar`, which is not FFI-safe

warning: `extern` fn uses type `dyn PluginRegistrar`, which is not FFI-safe
  --> core/src/lib.rs:26:19
   |
26 |     pub register: unsafe extern "C" fn(&mut dyn PluginRegistrar),
   |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
   |
   = note: trait objects have no C equivalent
   = note: `#[warn(improper_ctypes_definitions)]` on by default