fix(iframe-fixes): add test (#21)

Fixes #18
silbinarywolf · Nov 28, 2019 · 5148446 · 5148446
1 parent df74f0e
commit 5148446
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/cypress/integration/unit/iframe-fixes.ts b/cypress/integration/unit/iframe-fixes.ts
@@ -21,6 +21,11 @@ describe('IframeFixes', () => {
     cy.get('.bodyAppendChild').should('exist');
   });
 
+  it('Check document.body.removeChild override is active', () => {
+    component.create(bootstrap);
+    cy.get('.bodyAppendAndRemoveChild').should('not.exist');
+  });
+
   it('Check document.querySelector override is active', () => {
     component.create(bootstrap);
     cy.get('.documentQuerySelectorSuccess').should('exist');

diff --git a/lib/iframe-fixes.ts b/lib/iframe-fixes.ts
@@ -69,7 +69,7 @@ function overrideSpecIFrameToApplyToAppIFrame(): void {
   // end up causing "The node to be removed is not a child of this node." errors.
   {
     const bodyRemoveChild = function <T extends Node>(this: T): T {
-      return appDocument.body.removeChild.apply(appDocument, arguments as any) as T;
+      return appDocument.body.removeChild.apply(appDocument.body, arguments as any) as T;
     };
     if (specDocument.body.removeChild !== bodyRemoveChild) {
       specDocument.body.removeChild = bodyRemoveChild;

diff --git a/src/document-manipulator/document-manipulator.ts b/src/document-manipulator/document-manipulator.ts
@@ -22,6 +22,13 @@ export class DocumentManipulator {
       document.body.appendChild(el);
     }
 
+    {
+      const el = document.createElement('div');
+      el.classList.add('bodyAppendAndRemoveChild');
+      el.textContent = '- bodyAppendAndRemoveChild';
+      document.body.appendChild(el);
+    }
+
     {
       const el = document.querySelector('document-manipulator');
       if (el) {