feat:新增JS-SDK使用权限签名 #796
Open
feat:新增JS-SDK使用权限签名 #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseme
reviewed
Sep 27, 2024
| func (js *Js) GetAgentConfig(uri string) (config *Config, err error) { | ||
| config = new(Config) | ||
| var accessToken string | ||
| accessToken, err = js.GetAccessToken() |
There was a problem hiding this comment.
73,74合并处理，下面的78，79也是一样，以及83-86 是不是可以合并定义呢？
houseme
reviewed
Sep 27, 2024
| if isApp { | ||
| url = fmt.Sprintf(getQyAppTicketURL, accessToken) | ||
| } | ||
| response, err = util.HTTPGet(url) |
There was a problem hiding this comment.
67行的定义可以延后定义，在72行在定义，72和73可以合并处理，下面76、77 也可以合并处理，其他函数也是同样处理一下
houseme
reviewed
Oct 8, 2024
| // GetAgentConfig 获取jssdk需要的配置参数 | ||
| // uri 为当前网页地址 | ||
| func (js *Js) GetAgentConfig(uri string) (config *Config, err error) { | ||
| config = new(Config) |
There was a problem hiding this comment.
建议 Config 对象在使用时在创建，如在88行之前创建。GetConfig 方法也是同样建议
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.work.weixin.qq.com/document/path/90506