Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent error when run-bakery is called without any arguments #43

Merged
merged 1 commit into from
Feb 2, 2025
Merged

fix: prevent error when run-bakery is called without any arguments #43

merged 1 commit into from
Feb 2, 2025

Conversation

reubenmiller
Copy link
Contributor

Due to the usage of the shell option u, calling the run-bakery script without any arguments causes an error due to referencing $1:

./run-bakery            
bash: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8): No such file or directory
./run-bakery: line 31: $1: unbound variable

By specifying a defualt value via ${1:-}, it avoids the unbound variable issue.

@koehlma koehlma merged commit ce40740 into silitics:main Feb 2, 2025
12 of 14 checks passed
koehlma pushed a commit that referenced this pull request Feb 2, 2025
@reubenmiller @koehlma
fix: prevent error when run-bakery is called without any arguments (#43)
8355034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reubenmiller @koehlma