Skip to content

Implement testing plugin#47

Merged
BadMagic100 merged 7 commits intosilksong-modding:mainfrom
dplochcoder:test
Mar 11, 2026
Merged

Implement testing plugin#47
BadMagic100 merged 7 commits intosilksong-modding:mainfrom
dplochcoder:test

Conversation

@dplochcoder
Copy link
Contributor

Implements a testing plugin to enable easier debugging of new mod menu features. Also fixes at least one bug found along the way.

@BadMagic100
Copy link
Member

  1. Are the git hooks actually working as intended here? I was under the impression it won't work if it's not at the repo root
  2. Fwiw it's easier to review the inter-revision diff if you don't force push, I'll usually end up squashing anyway

@dplochcoder
Copy link
Contributor Author

dplochcoder commented Mar 10, 2026

  1. Are the git hooks actually working as intended here? I was under the impression it won't work if it's not at the repo root

It's never worked for me so idk, I've resorted to running csharpier manually.

  1. Fwiw it's easier to review the inter-revision diff if you don't force push, I'll usually end up squashing anyway

Done.

@BadMagic100
Copy link
Member

BadMagic100 commented Mar 10, 2026

On 1, the way to know would be to check if your commit is taking seconds instead of milliseconds (running the build). I can do a spot check on it this evening though

@BadMagic100 BadMagic100 self-requested a review March 11, 2026 01:28
Copy link
Member

@BadMagic100 BadMagic100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it works. It was easy to verify

$ git commit --allow-empty -m "check precommit"
[Husky] 🚀 Loading tasks ...
--------------------------------------------------
[Husky] ⚡ Preparing task 'Format and build'
[Husky] ⌛ Executing task 'Format and build' ...
...

@BadMagic100 BadMagic100 merged commit 45960a8 into silksong-modding:main Mar 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants