-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LT-21633: Improve Bidi handling in Word Export #15
Conversation
- Remove unneeded TextDirection property. - Create Writing System styles so that they are based on styles that they should inherit from. Change-Id: I199bb153c039acf78932f990117ad513398807af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @aror92)
Src/xWorks/WordStylesGenerator.cs
line 292 at r1 (raw file):
// If text direction is right to left, add BiDi property to the paragraph. if (exportStyleInfo.DirectionIsRightToLeft != TriStateBool.triNotSet)
Can you remove this outer if check?
Code quote:
if (exportStyleInfo.DirectionIsRightToLeft != TriStateBool.triNotSet)
Src/xWorks/WordStylesGenerator.cs
line 296 at r1 (raw file):
if (exportStyleInfo.DirectionIsRightToLeft == TriStateBool.triTrue) { parProps.Append(new BiDi());//BiDi = new BiDi());
Remove comment.
Code quote:
//BiDi = new BiDi());
- Remove unneeded TextDirection property. - Create Writing System styles so that they are based on styles that they should inherit from. Change-Id: I199bb153c039acf78932f990117ad513398807af
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @aror92)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @mark-sil)
Src/xWorks/WordStylesGenerator.cs
line 292 at r1 (raw file):
Previously, mark-sil (Mark Kidder) wrote…
Can you remove this outer if check?
Done.
Src/xWorks/WordStylesGenerator.cs
line 296 at r1 (raw file):
Previously, mark-sil (Mark Kidder) wrote…
Remove comment.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @aror92)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aror92)
This change is