[ReviewEntries] Prevent duplicate semantic domain on a sense (#2573)

sillsdev · Sep 14, 2023 · 51243a5 · 51243a5
1 parent db14c8c
commit 51243a5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/public/locales/en/translation.json b/public/locales/en/translation.json
@@ -269,6 +269,7 @@
     "noDefinition": "No definitions input",
     "noGloss": "No glosses input",
     "noDomain": "No domain selected",
+    "duplicateDomain": "This sense already has domain {{ val }}.",
     "noNote": "No note",
     "deleteWordWarning": "This word will be permanently deleted!",
     "deleteDisabled": "This was imported with data that The Combine doesn't handle, so it may not be deleted.",

diff --git a/src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/DomainCell.tsx b/src/goals/ReviewEntries/ReviewEntriesComponent/CellComponents/DomainCell.tsx
@@ -3,6 +3,7 @@ import { Chip, Dialog, Grid, IconButton } from "@mui/material";
 import React, { ReactElement, useState } from "react";
 import { useTranslation } from "react-i18next";
 import { useSelector } from "react-redux";
+import { toast } from "react-toastify";
 
 import { SemanticDomain } from "api/models";
 import { getCurrentUser } from "backend/localStorage";
@@ -47,7 +48,13 @@ export default function DomainCell(props: DomainCellProps): ReactElement {
         );
       }
       if (selectedDomain.mongoId == "") {
-        throw new Error("SelectedSemanticDomainTreeNode have no mongoId");
+        throw new Error("SelectedSemanticDomainTreeNode have no mongoId.");
+      }
+      if (senseToChange.domains.find((d) => d.id === selectedDomain.id)) {
+        toast.error(
+          t("reviewEntries.duplicateDomain", { val: selectedDomain.id })
+        );
+        return;
       }
       props.editDomains(senseToChange.guid, [
         ...senseToChange.domains,