-
-
Notifications
You must be signed in to change notification settings - Fork 10
[MergeDups] Separate identical vs similar duplicate finding with intermediate dialog #4039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…egration Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
Co-authored-by: imnasnainaec <6411521+imnasnainaec@users.noreply.github.com>
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4039 +/- ##
==========================================
- Coverage 74.66% 74.47% -0.19%
==========================================
Files 293 295 +2
Lines 10890 10939 +49
Branches 1364 1369 +5
==========================================
+ Hits 8131 8147 +16
- Misses 2362 2396 +34
+ Partials 397 396 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When all identical-vernacular duplicates are processed, users need feedback and a choice before the system searches for similar duplicates (which can take minutes on large projects).
Backend Changes
New endpoint
FindIdenticalPotentialDuplicatesFindPotentialDuplicateswhich uses async/SignalR for similar matchesRefactored
MergeService.GetPotentialDuplicatesidenticalVernacularparametertrue→GetIdenticalVernWords,false→GetSimilarWordsFrontend Changes
Modified MergeDups flow
IdenticalDuplicatesDialogNew
IdenticalDuplicatesDialogcomponentAdded
DataLoadStatus.IdenticalCompletedExample Flow
The change provides clear feedback at a natural breakpoint while maintaining backward compatibility with the async similar-duplicate search.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
This change is