Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow configuration data to WorkflowDefinitions table #1026

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

FyreByrd
Copy link

Added two fields to WorkflowDefinitions:

  • ProductType: an integer that represents the ProductType enum in common/public/workflow.ts
  • AdminRequirements: an array of integers that represent the WorkflowAdminRequirements enum in common/public/workflow.ts

@FyreByrd
Copy link
Author

I am not 100% sold on the fields being integers. It would be somewhat more readable if they were strings. This would probably require changing the underlying data type of the enums to be strings, which could possibly cause a performance hit for using them as often as they are used.

@chrisvire
Copy link
Member

@FyreByrd Is this to get these config out of the TypeScript code and into the database? For future Workflow Definitions, we will need UI to edit/add these settings?

@FyreByrd
Copy link
Author

@FyreByrd Is this to get these config out of the TypeScript code and into the database? For future Workflow Definitions, we will need UI to edit/add these settings?

Yes. I do intend to add UI for that as well, but I wasn't sure whether that should be part of this PR or a different one. I've been trying to keep DB changes as separate minimal PRs.

@chrisvire
Copy link
Member

@FyreByrd Yes, I think it is good to have separate PRs. You could use interactive rebasing to have the database in one commit and the UI in one comment. It is just a matter of making sure to do a Rebase and merge instead of Squash and merge. Realistically, separate PRs are probably better.

Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@FyreByrd FyreByrd merged commit 600518a into feature/svelte Oct 31, 2024
2 checks passed
@FyreByrd FyreByrd deleted the fix/prisma-workflow-configuration branch October 31, 2024 19:43
@FyreByrd
Copy link
Author

FyreByrd commented Nov 1, 2024

We may want to remove WorkflowScheme and WorkflowBusinessFlow from the WorkflowDefinitions table in the future. Of course, those will remain for now, in keeping with backwards compatibility with S1 during development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants