Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add functionality for play mode button #402

Merged
merged 5 commits into from
Oct 8, 2023

Conversation

ChristopherRankin
Copy link
Contributor

Adds functionality for each mode with continue, stop, repeat page, and repeat selection.

Adds functionality for each mode with continue, stop, repeat page, and
repeat selection.
@ChristopherRankin ChristopherRankin changed the title This commit adds functionality for the play mode button add functionality for play mode button Aug 24, 2023
@chrisvire
Copy link
Member

@ChristopherRankin: I am sorry it has taken so long to get to this. Do I need to fix issues or would you have time to look at things?

I noticed that when the mode is stop at the end of the page, the play/pause button still displays that it is playing (i.e. the pause button is showing).

ChristopherRankin and others added 3 commits August 31, 2023 11:30
This shows the play button if the playmode is set to stop and the audio is ended.
@chrisvire chrisvire self-requested a review October 8, 2023 21:09
Copy link
Member

@chrisvire chrisvire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisvire chrisvire merged commit 664ab5d into sillsdev:main Oct 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants