Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Contents Menu Launch Action #653

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Support Contents Menu Launch Action #653

merged 1 commit into from
Jul 24, 2024

Conversation

chrisvire
Copy link
Member

  • move scripture display to /text route
  • fix firstLaunch so that it can be handled by start page and text page
  • handle query string parameters in start page
  • use navigate function to add query string ref to history

@chrisvire
Support Contents Menu Launch Action
bb38fa8 
* move scripture display to /text route
* fix firstLaunch so that it can be handled by start page
  and text page
* handle query string parameters in start page
* use navigate function to add query string ref to history
davidmoore1
davidmoore1 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@davidmoore1 davidmoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with the one comment about the console.log line that may not be wanted.

src/routes/text/+page.svelte
savedScrollPosition = 0;
});
async function doSwipe(event) {
console.log('SWIPE', event.detail.direction);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to leave this in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already there. It will be remove when I implement the carousel.

@chrisvire chrisvire linked an issue Jul 24, 2024 that may be closed by this pull request
Contents: Implement Launch Action and navigation #613
Closed
@chrisvire chrisvire merged commit def70ab into sillsdev:main Jul 24, 2024
1 check passed
@chrisvire chrisvire deleted the feature/text-route branch July 24, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmoore1 davidmoore1 davidmoore1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contents: Implement Launch Action and navigation
2 participants
@chrisvire @davidmoore1