-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mac support for library loading #142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment to CHANGELOG.md
- seems worth mentioning that Mac is now supported, and add +semver:minor
to the commit message.
If the method names on Mac are the same as on Linux, we should solve this differently:
-
change
LIBDL_NAME
:private const string LIBDL_NAME = "libdl.so";
-
modify
App.config
and add:<configuration> <dllmap os="!windows,osx" dll="libdl.so" target="libdl.so.2" /> <dllmap os="osx" dll="libdl.so" target="libdl.dylib"/> </configuration>
252c19b
to
7b6ccd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:lgtm:
@jasonleenaylor I will remove myself from the reviewers. I have never done this so I don't know. |
I'm still encountering |
The problem is that the nuget package is missing the |
I have the same issue as well, even adding the config file, for some reason the DLL map is not working on mac |
@martin-shields-sage What mono version are you using? What icu-dotnet version? And can you show the exception you're getting including a stack trace? |
Exception Message: Stack Trace: Mono Version For some reason it appears to be ignoring the config file which was added and insisting on using libdl.so instead of libdl.dylib. Not sure if I am doing something wrong but I ran dotnet pack on the project and used that nuget package which did include the config file |
Unfortunately I don't have a Mac available, so can't test this. Make sure you have the |
Addresses issue #141