Make sync API consistent: always (before, after) #540
Triggered via pull request
December 18, 2024 15:14
myieye
Status
Failure
Total duration
11m 19s
Artifacts
–
fw-lite.yaml
on: pull_request
Build FW Lite and run tests
11m 6s
Publish FW Lite app for Mac
0s
Publish FW Lite app for Linux
0s
Publish FW Lite app for Windows
0s
Create Release
0s
Annotations
2 errors and 10 warnings
|
Build FW Lite and run tests:
backend/FwLite/FwLiteProjectSync.Tests/UpdateDiffTests.cs#L42
'UpdateObjectInput<Sense>' does not contain a definition for 'GetAwaiter' and no accessible extension method 'GetAwaiter' accepting a first argument of type 'UpdateObjectInput<Sense>' could be found (are you missing a using directive or an assembly reference?)
|
|
Build FW Lite and run tests
Process completed with exit code 1.
|
|
Build FW Lite and run tests:
backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L208
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build FW Lite and run tests:
backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
|
|
Build FW Lite and run tests:
backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L382
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
|
|
Build FW Lite and run tests:
backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
|