Skip to content

Make sync API consistent: always (before, after) (#1303) #543

Make sync API consistent: always (before, after) (#1303)

Make sync API consistent: always (before, after) (#1303) #543

Triggered via push December 19, 2024 03:49
Status Success
Total duration 40m 45s
Artifacts 5

fw-lite.yaml

on: push
Build FW Lite and run tests
26m 12s
Build FW Lite and run tests
Publish FW Lite app for Mac
1m 8s
Publish FW Lite app for Mac
Publish FW Lite app for Linux
1m 5s
Publish FW Lite app for Linux
Publish FW Lite app for Windows
14m 10s
Publish FW Lite app for Windows
Create Release
0s
Create Release
Fit to window
Zoom out
Zoom in

Annotations

77 warnings
Build FW Lite and run tests: backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L208
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build FW Lite and run tests: backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
Build FW Lite and run tests: backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
Build FW Lite and run tests: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
Build FW Lite and run tests: backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build FW Lite and run tests: backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build FW Lite and run tests: backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
Build FW Lite and run tests: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Build FW Lite and run tests: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Build FW Lite and run tests: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L382
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Linux
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Publish FW Lite app for Linux: backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L208
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Linux: backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
Publish FW Lite app for Linux: backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L382
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Linux: backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L208
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Linux: backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
Publish FW Lite app for Linux: backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Linux: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L382
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Mac: backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L208
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Mac: backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
Publish FW Lite app for Mac: backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L382
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Mac: backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L208
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Mac: backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
Publish FW Lite app for Mac: backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Mac: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L382
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Windows
Unexpected input(s) 'clickonce-application-name', 'clickonce-publisher-name', valid inputs are ['azure-tenant-id', 'azure-client-id', 'azure-client-secret', 'azure-client-certificate-path', 'azure-client-send-certificate-chain', 'azure-username', 'azure-password', 'endpoint', 'code-signing-account-name', 'trusted-signing-account-name', 'certificate-profile-name', 'files', 'files-folder', 'files-folder-filter', 'files-folder-recurse', 'files-folder-depth', 'files-catalog', 'file-digest', 'timestamp-rfc3161', 'timestamp-digest', 'append-signature', 'description', 'description-url', 'generate-digest-path', 'generate-digest-xml', 'ingest-digest-path', 'sign-digest', 'generate-page-hashes', 'suppress-page-hashes', 'generate-pkcs7', 'pkcs7-options', 'pkcs7-oid', 'enhanced-key-usage', 'exclude-environment-credential', 'exclude-workload-identity-credential', 'exclude-managed-identity-credential', 'exclude-shared-token-cache-credential', 'exclude-visual-studio-credential', 'exclude-visual-studio-code-credential', 'exclude-azure-cli-credential', 'exclude-azure-powershell-credential', 'exclude-azure-developer-cli-credential', 'exclude-interactive-browser-credential', 'timeout', 'batch-size', 'cache-dependencies', 'trace']
Publish FW Lite app for Windows
Unexpected input(s) 'clickonce-application-name', 'clickonce-publisher-name', valid inputs are ['azure-tenant-id', 'azure-client-id', 'azure-client-secret', 'azure-client-certificate-path', 'azure-client-send-certificate-chain', 'azure-username', 'azure-password', 'endpoint', 'code-signing-account-name', 'trusted-signing-account-name', 'certificate-profile-name', 'files', 'files-folder', 'files-folder-filter', 'files-folder-recurse', 'files-folder-depth', 'files-catalog', 'file-digest', 'timestamp-rfc3161', 'timestamp-digest', 'append-signature', 'description', 'description-url', 'generate-digest-path', 'generate-digest-xml', 'ingest-digest-path', 'sign-digest', 'generate-page-hashes', 'suppress-page-hashes', 'generate-pkcs7', 'pkcs7-options', 'pkcs7-oid', 'enhanced-key-usage', 'exclude-environment-credential', 'exclude-workload-identity-credential', 'exclude-managed-identity-credential', 'exclude-shared-token-cache-credential', 'exclude-visual-studio-credential', 'exclude-visual-studio-code-credential', 'exclude-azure-cli-credential', 'exclude-azure-powershell-credential', 'exclude-azure-developer-cli-credential', 'exclude-interactive-browser-credential', 'timeout', 'batch-size', 'cache-dependencies', 'trace']
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L382
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Windows: backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L208
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Windows: backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
Publish FW Lite app for Windows: backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
Publish FW Lite app for Windows: backend/FwLite/FwLiteDesktop/ServerBridge/ServerManager.cs#L40
Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
Publish FW Lite app for Windows: backend/FwLite/FwLiteDesktop/ServerBridge/ServerManager.cs#L48
Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
Publish FW Lite app for Windows: backend/FwLite/FwLiteDesktop/ServerBridge/ServerManager.cs#L49
Synchronously waiting on tasks or awaiters may cause deadlocks. Use await or JoinableTaskFactory.Run instead. (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD002.md)
Publish FW Lite app for Windows: backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs#L208
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Windows: backend/FwLite/FwDataMiniLcmBridge/LcmUtils/LcmThreadedProgress.cs#L10
The event 'LcmThreadedProgress.Canceling' is never used
Publish FW Lite app for Windows: backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs#L121
Observe the awaitable result of this method call by awaiting it, assigning to a variable, or passing it to another method (https://github.com/Microsoft/vs-threading/blob/main/doc/analyzers/VSTHRD110.md)
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L19
Parameter 'dbContext' is unread.
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/Changes/RemoveSemanticDomainChange.cs#L11
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/RemoteSync/CrdtHttpSyncService.cs#L53
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/Data/SetupCollationInterceptor.cs#L27
The variable 'e' is declared but never used
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/HistoryService.cs#L94
The result of the expression is always 'true' since a value of type 'Guid' is never equal to 'null' of type 'Guid?'
Publish FW Lite app for Windows: backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs#L382
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Artifacts

Produced during runtime
Name Size Digest
fw-lite-local-web-app-linux Expired
54.8 MB
sha256:266d572520aa36d0ff942f68532b8e36b4e6a5c1ba1441ea5a39a82c372c10bd
fw-lite-local-web-app-mac Expired
112 MB
sha256:08631c822219f2051fd40673574e79b7c32d3c7db9394585c7b22f11d40c05e2
fw-lite-msix Expired
151 MB
sha256:6bbf032c75601c8823e3f1d7b348f1a2d5452c35a690467ceaf4b5352143a3c9
fw-lite-portable Expired
187 MB
sha256:37f42b1d0bb81bea838f7040867abc55f494650a6ed2029f91b1436112b0e177
fw-lite-viewer-app Expired
552 KB
sha256:7c825bd468eae2fac662a0c72b3dea002891027f34473d8d3ae130080c443a9c