Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crdt demo #1053

Merged
merged 28 commits into from
Oct 2, 2024
Merged

Crdt demo #1053

merged 28 commits into from
Oct 2, 2024

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Sep 11, 2024 •
edited
Loading

features

  • upload project to server
  • set dev mode in browser from backend
  • filter changes pushed by current filter
  • add missing entries that come from pushed changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

UI unit Tests

12 tests  ±0   12 ✅ ±0   0s ⏱️ ±0s
 4 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 9de8d9a. ± Comparison against base commit e75aa06.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

C# Unit Tests

71 tests  ±0   71 ✅ ±0   6s ⏱️ -1s
12 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 9de8d9a. ± Comparison against base commit e75aa06.

♻️ This comment has been updated with latest results.

myieye
myieye requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a partial review sadly.
I'll try to finish tomorrow.
I'm posting it to make my progress official 😉.

backend/FwLite/FwLiteDesktop/MainPage.xaml.cs Outdated Show resolved Hide resolved
backend/FwLite/LcmCrdt/SqlHelpers.cs Show resolved Hide resolved
backend/FwLite/LocalWebApp/Hubs/CrdtMiniLcmApiHub.cs Outdated Show resolved Hide resolved
backend/FwLite/LocalWebApp/Hubs/CrdtMiniLcmApiHub.cs Outdated Show resolved Hide resolved
backend/FwLite/LocalWebApp/Hubs/CrdtMiniLcmApiHub.cs Show resolved Hide resolved
backend/FwLite/LocalWebApp/LocalWebAppServer.cs Outdated Show resolved Hide resolved
backend/FwLite/LocalWebApp/Routes/AuthRoutes.cs Outdated Show resolved Hide resolved
myieye
myieye previously approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM 😎

I added 2 tiny commits as I found small UI bugs and such...maybe I should have put them in my own PR.

backend/FwLite/FwLiteDesktop/MainPage.xaml.cs Outdated Show resolved Hide resolved
backend/FwLite/LocalWebApp/appsettings.json Outdated Show resolved Hide resolved
frontend/viewer/src/lib/layout/ViewOptionsDrawer.svelte Outdated Show resolved Hide resolved
frontend/viewer/src/lib/layout/EntryList.svelte Show resolved Hide resolved
@hahn-kev hahn-kev merged commit 3dffa35 into develop Oct 2, 2024
20 checks passed
@hahn-kev hahn-kev deleted the crdt-demo branch October 2, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myieye myieye myieye left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hahn-kev @myieye