Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update projects to target dotnet 9 #1057

Draft
wants to merge 26 commits into
base: develop
Choose a base branch
from
Draft

update projects to target dotnet 9 #1057

wants to merge 26 commits into from

Conversation

hahn-kev
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Sep 23, 2024

C# Unit Tests

90 tests  ±0   82 ✅  - 8   16s ⏱️ +11s
14 suites ±0    0 💤 ±0 
 1 files   ±0    8 ❌ +8 

For more details on these failures, see this check.

Results for commit dc17b73. ± Comparison against base commit 022f8b5.

♻️ This comment has been updated with latest results.

@rmunn
Copy link
Contributor

rmunn commented Sep 24, 2024

Curious what the benefit of moving to .NET 9 is, specifically. Is it the HybridWebView control in MAUI that we want to use? Or is this just on general principles of keeping up with the latest .NET version?

@hahn-kev
Copy link
Collaborator Author

It's just keeping up with the latest version as it comes out, in my mind we should always be on latest unless there's a specific reason not to be.

# Conflicts:
#	.github/workflows/lexbox-api.yaml
#	backend/FwLite/FwDataMiniLcmBridge/FwDataMiniLcmBridge.csproj
#	backend/FwLite/FwLiteProjectSync/FwLiteProjectSync.csproj
#	backend/FwLite/LcmCrdt/LcmCrdt.csproj
#	backend/FwLite/MiniLcm/MiniLcm.csproj
@rmunn
Copy link
Contributor

rmunn commented Nov 13, 2024

.NET 9 is now officially released. It hasn't shown up in the Ubuntu repositories yet, but that's only a matter of time.

# Conflicts:
#	.github/workflows/fw-lite.yaml
#	backend/FwLite/LocalWebApp/Routes/HistoryRoutes.cs
#	backend/FwLite/MiniLcm.Tests/MiniLcm.Tests.csproj
#	backend/FwLite/MiniLcm/MiniLcm.csproj
#	backend/harmony
…it/VsTestRunner2/netcoreapp' were found. Ignoring adapter 'Xunit.Runner.VisualStudio.VsTestRunner'. Please uninstall the conflicting adapter(s) to avoid this warning.'
@hahn-kev
Copy link
Collaborator Author

looks like our current test failure is running into this bug
dotnet/efcore#35110
Sadly I'm not sure how to make a simple repro, so I'm going to wait and see if someone else comes up with something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants