Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex forms in miniLcm #1061

Merged
merged 25 commits into from
Oct 11, 2024
Merged

Complex forms in miniLcm #1061

merged 25 commits into from
Oct 11, 2024

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Sep 23, 2024

this is just a first pass at what Complex Forms might look like. I'd like to get some input on how well this models complex forms and what might be missing

  • reading
  • writing changes (backend only)
  • CRDT

Copy link

github-actions bot commented Sep 23, 2024

C# Unit Tests

75 tests  ±0   75 ✅ ±0   6s ⏱️ ±0s
13 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 557be8e. ± Comparison against base commit c7e9364.

♻️ This comment has been updated with latest results.

@hahn-kev hahn-kev changed the title Complex forms ini miniLcm Complex forms in miniLcm Sep 24, 2024
@hahn-kev hahn-kev mentioned this pull request Sep 27, 2024
2 tasks
@hahn-kev hahn-kev requested a review from myieye October 9, 2024 05:36
myieye
myieye previously approved these changes Oct 10, 2024
Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a few minor suggestions and such. But, I don't see anything that's really wrong here.

# Conflicts:
#	backend/FwLite/MiniLcm/Models/Entry.cs
@hahn-kev hahn-kev merged commit cbcb6a1 into develop Oct 11, 2024
13 checks passed
@hahn-kev hahn-kev deleted the feat/complex-forms branch October 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants