Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complex form type validation #1282

Merged
merged 7 commits into from
Nov 29, 2024
Merged

complex form type validation #1282

merged 7 commits into from
Nov 29, 2024
+189 −9

Conversation

hahn-kev
Copy link
Collaborator

closes #1274

implements complex form type validation when creating a new complex form type, it does not implement validation for updates as those methods are pending #1281

@hahn-kev hahn-kev mentioned this pull request Nov 26, 2024
Closed
@hahn-kev hahn-kev requested a review from rmunn November 26, 2024 06:18
myieye
myieye requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@myieye myieye left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all, I think this looks really nice 👍

I think my request for a custom validation message for sense<->entry references is worth implementing. Everything else is just ideas.

backend/FwLite/MiniLcm/Validators/MiniLcmValidators.cs Show resolved Hide resolved
backend/FwLite/MiniLcm/Validators/MultiStringValidator.cs Outdated Show resolved Hide resolved
backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs Outdated Show resolved Hide resolved
backend/FwLite/MiniLcm/Validators/SenseValidator.cs Outdated Show resolved Hide resolved
@hahn-kev
Merge branch 'develop' into chore/complex-form-type-validation
02d0e3e 
# Conflicts:
#	backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs
@hahn-kev hahn-kev merged commit c6d233f into develop Nov 29, 2024
11 checks passed
@hahn-kev hahn-kev deleted the chore/complex-form-type-validation branch November 29, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myieye myieye myieye requested changes

@rmunn rmunn Awaiting requested review from rmunn

Assignees

@myieye myieye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

validate complex form types
2 participants
@hahn-kev @myieye