Prevent duplicate user email #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tall for check and build.
hahn-kev
force-pushed
the
prevent-duplicate-user-email
branch
from
e0b60e6
to
d7ffb4c
Compare
myieye
approved these changes
Sep 4, 2023
Co-authored-by: Tim Haasdyk <myieye@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #208
created a collation in the db called
case_insensitiveany column (or comparison) that uses this collation will be done in a case insensitive manner. Collations can be applied per expression. For examplewhere user = 'test'will use the default column collation or if you wanted to be explicitwhere user = 'test' COLLATE "case_insensitive"now the comparison is case insensitive. My fix is to make the email column case insensitive by setting it's default collation. If for some reason we wanted to do a case sensitive comparison we could do this:where email = 'something' collate "default"now thecase_insensitivecollation won't be used for that expression. The equivelent in EF would be this:Where(u => EF.Functions.Collate(u.Email, "default") == "test@email")this also required making some changes to how this error is handled on the client side. Now the form modal callback can return either a string for a generic error message, or an object (matching the superform errors type) with errors per column. I only made this change to the Form modal, but it might also make sense to apply to the form callback also.