Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rendering performance when filtering large project and user counts #266

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

hahn-kev
Copy link
Collaborator

@hahn-kev hahn-kev commented Sep 5, 2023

when there's a large number of users the previous implementation would render too much html slowing down the browser. We want to limit that.

@hahn-kev hahn-kev requested a review from myieye September 5, 2023 06:22
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

UI unit Tests

1 tests   1 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit eb404ac.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

frontend/src/routes/(authenticated)/admin/+page.svelte Outdated Show resolved Hide resolved
frontend/src/routes/(authenticated)/admin/+page.svelte Outdated Show resolved Hide resolved
frontend/src/routes/(authenticated)/admin/+page.svelte Outdated Show resolved Hide resolved
frontend/src/routes/(authenticated)/admin/+page.svelte Outdated Show resolved Hide resolved
@hahn-kev hahn-kev merged commit 571ce34 into develop Sep 6, 2023
5 of 6 checks passed
@hahn-kev hahn-kev deleted the fix-perf-admin-large-row-count branch July 9, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants