Stabilise email-result handling #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hahn-kev
reviewed
Oct 31, 2023
| @@ -16,9 +16,13 @@ export const load = (({ url }) => { | |||
| const emailResult = url.searchParams.get('emailResult') as EmailResult | null; | |||
| if (emailResult) { | |||
| if (!EMAIL_RESULTS.includes(emailResult)) throw new Error(`Invalid emailResult: ${emailResult}.`); | |||
| if (browser) void goto(`${url.pathname}`, { replaceState: true }); | |||
| if (browser) { | |||
| void goto(`${url.pathname}`, { replaceState: true }); | |||
There was a problem hiding this comment.
are we sure this isn't what's causing issues? this is just to remove the search param from the url to keep it pretty right? If that's the case maybe we should just remove it.
There was a problem hiding this comment.
Very good idea 😆.
I just removed the troublesome, unnecessarily complicated, minor UX feature.
myieye
force-pushed
the
stabilise-email-result-handling
branch
from
c80a629
to
c32d988
Compare
myieye
force-pushed
the
stabilise-email-result-handling
branch
from
c32d988
to
6a9450d
Compare
|
I also greatly simplified closing the banner/notification. |
|
@hahn-kev feel free to review again, but it seemed pretty safe to merge and there are a lot of PRs open, so I just went for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This load function is fragile. It was tricky setting it up and when I changed to CSR (for experimentation) it stopped working.
I think we're generally not supposed to use stores in load functions, but I also think it's fine if it's only client-side. So, I think this is a good change, but I'm putting it in a PR so it's more visible.