Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: 347 make playwright wait for hydrated not networkidle #354

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Test: 347 make playwright wait for hydrated not networkidle #354

merged 5 commits into from
Nov 2, 2023

Commits on Oct 27, 2023

  1. Add loading overlay while hydrating

    @myieye
    myieye committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    5b79da9 View commit details
    Browse the repository at this point in the history

  2. Use skeleton/hide elements during hydration 

    Instead of covering with overlay, because
(1) it's weird to cover up a loaded page
(2) it doesn't block keypresses
    @myieye
    myieye committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    e64e8e8 View commit details
    Browse the repository at this point in the history

  3. Wait for Load instead of NetworkIdle 

    We don't have to wait until NetworkIdle/Hydrated, because the app blocks user interaction automatically.
    @myieye
    myieye committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    b6aa726 View commit details
    Browse the repository at this point in the history

  4. Use simpler hydration/loading animation

    @myieye
    myieye committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    1311e97 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Rename variable to 'hydrating'

    @myieye
    myieye committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9dad138 View commit details
    Browse the repository at this point in the history