Skip to content

Truncate some values on admin dashboard #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

myieye
Copy link
Contributor

@myieye myieye commented Mar 28, 2024

Fixes #461 (properly?)

image

From my testing it seems that the scroll shadow might lead to some annoying rendering noise, so we can remove it again if it turns out to be too ugly:
https://github.com/sillsdev/languageforge-lexbox/assets/12587509/10873591-b0e7-4524-a2f6-f1e4a0a954fc

Copy link

github-actions bot commented Mar 28, 2024

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit e13bef6. ± Comparison against base commit ce3efe9.

♻️ This comment has been updated with latest results.

@myieye myieye requested a review from hahn-kev March 28, 2024 14:47
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like the shadow, we'll see how it goes over.

@rmunn
Copy link
Contributor

rmunn commented Apr 1, 2024

I suspect this might cause some E2E tests to fail, as the GUID they're looking for becomes hidden away behind the ellipsis; better run pnpm test before you merge this.

@myieye myieye merged commit 20d8425 into develop Apr 3, 2024
@myieye myieye deleted the fix/admin-tables-still-overflow branch April 3, 2024 14:12
@myieye
Copy link
Contributor Author

myieye commented Apr 3, 2024

I can run all the e2e tests locally.
The most common reason for flaky failures are HMR errors 😠.
I don't know how to avoid those.

@megahirt
Copy link
Contributor

megahirt commented Apr 4, 2024

What are "HMR" errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain screen sizes make it difficult to notice that tables are scrollable
4 participants