configure openid connect #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re out how to we want to do key storage in production
…s handled by aspnet it'll result in a redirect loop
…to end up in ID token for testing purposes
UI unit Tests11 tests 11 ✅ 0s ⏱️ Results for commit aabb651. ♻️ This comment has been updated with latest results. |
…e where openId is disabled
# Conflicts: # backend/LexBoxApi/LexBoxApi.csproj # backend/LexData/LexData.csproj
…p and with proper CORS headers
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .Add("appName", await applicationManager.GetDisplayNameAsync(application) ?? "Unknown app") | ||
| .Add("scope", request.Scope ?? "") | ||
| .Add("postback", data); | ||
| return Redirect($"/authorize{queryString.Value}"); |
Check warning
Code scanning / CodeQL
URL redirection from remote source
| return BadRequest(); | ||
| } | ||
|
|
||
| if (IsAcceptRequest()) |
Check failure
Code scanning / CodeQL
User-controlled bypass of sensitive method
…edirects somewhere
…was always null in `CompleteGoogleLogin` due to using the wrong property.
myieye
reviewed
May 23, 2024
|
I did a little design work on this.
|
myieye
approved these changes
May 28, 2024
# Conflicts: # backend/LexBoxApi/appsettings.Development.json # backend/LexData/Migrations/LexBoxDbContextModelSnapshot.cs
….cs, revert some changes made to vite.config.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR enables the use of openID connect to authenticate 3rd party apps with lexbox. For now this is disabled except in local dev, it's pending key storage decisions. We need to store signing and encryption keys somewhere and I'm not sure what the best option is right now for production.
How to test:
http://localhost:3000/api/login/open-id-authbecf2856-0690-434b-b192-a4032b72067fopenid profileReturnUrlquery parameter in the URL, login like normal (google login unknown?), once login is finished proceed to the next stepif you want to test out the access token (first box, very large token), you can execute a request like this:
it should return success with your users name. This represents a token that could be used by a 3rd party app like Language Forge, FLEx lite, or Living Dictionaries to access APIs on behalf of the user.
flow diagram:
flowchart TD approve{Has approved already} approveUser(Do you approve?) start[debugger authorize] -->|Logged in| approve start -->|Not logged in| login(Login) login --> approve approve -->|no| approveUser approve -->|yes| debugger approveUser -->|"Approve (success)"| debugger approveUser -->|"Deny (fail)"| debugger