Add fwddata bridge Semantic domains and Parts of speech #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmunn I requested your review since some of this code was taken directly from LF Merge and I want your feedback on it. Thanks |
hahn-kev
changed the title
… for the FwDataBridge pull part of speech helper methods into their own utility class rewrite semantic domain implementation to support them being objects that are referenced, instead of just being a string. prevent json patch changes from having index references, this will avoid conflicts where the index changes due to merges. introduce json patch rewriting to convert patches into specific changes. Rewrite changes to Sense.PartOfSpeechId into SetPartOfSpeechChange. allow creating parts of speech as CRDTs and setup a PoC of pre seeding them. allow creating semantic domains and referencing them in senses, rewrite json patch to change semantic domains of senses. Add tests for creating senses with and without semantic domains, and with and without part of speeches.
hahn-kev
force-pushed
the
feat/domain-and-pos-fw-updates
branch
from
192962b to
3e1cd70
Compare
hahn-kev
changed the base branch from
feat/import-fwdata-project-as-crdt
to
develop
…ild error due to 2 overloads not requiring parameters.
…ection fixture so it's shared by all tests in the project.
…hars instead of strings.
…nvariant on each string.
…nary, and set the MultiString capacity when converting a LcmMultiString to a MiniLcmMultiString
…cause first-char sounds like a better way to go (https://sil-lt.slack.com/archives/C806BLR42/p1718797173733449) This reverts commit 614dbd5.
…gle file until sillsdev/icu-dotnet#201 is merged.
|
@rmunn if you would take a look at this that would be great. Particularly the code in FwDataMiniLcmBridge and the related tests. |
rmunn
reviewed
Jul 4, 2024
backend/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #878
note this Pr is into the import PR as it builds on top of changes in that branch.
This adds support in the model only for actually properly referencing parts of speech and semantic domains when using the FWData api. Support still needs to be added for CRDTs and in the UI.
still todo: