Error thrown when trying to promote guest user to admin #892
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It works, but Zod is throwing a type error. @rmunn will follow up on this with more details. |
When you use the z.refine() function, it changes the type from ZodObject to ZodEffects, and some Zod type definitions don't apply to ZodEffects. Thankfully it's simple enough to split the schema and the refined schema into two objects and pass each one to the appropriate functions.
|
Type error fixed with commit 4085759. |
rmunn
requested changes
Jul 1, 2024
frontend/src/routes/(authenticated)/admin/EditUserAccount.svelte
Outdated
Show resolved
Hide resolved
frontend/src/routes/(authenticated)/admin/EditUserAccount.svelte
Outdated
Show resolved
Hide resolved
rmunn
approved these changes
Jul 2, 2024
hahn-kev
requested changes
Jul 4, 2024
frontend/src/routes/(authenticated)/admin/EditUserAccount.svelte
Outdated
Show resolved
Hide resolved
hahn-kev
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to promote guest user without an email to site admin, it throws an error.
To prevent this error, we can define a custom validation check on the schema.