Skip to content

Write code to programmatically check if our translations are up-to-date #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2024
Merged

Write code to programmatically check if our translations are up-to-date #902

merged 5 commits into from
Jul 3, 2024

Conversation

psh0078
Copy link
Collaborator

@psh0078 psh0078 commented Jun 27, 2024

Will fix #602

Create a update tracker that prints out all keys present in en.json that are missing from other translation files.

@psh0078 psh0078 self-assigned this Jun 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 27, 2024 •
edited
Loading

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 50d76a4. ± Comparison against base commit b2989d8.

♻️ This comment has been updated with latest results.

rmunn
rmunn requested changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still a draft PR, but I gave it a review anyway: there are several changes that will need to be made, and finding out about them early may save you time.

@psh0078 psh0078 marked this pull request as ready for review July 2, 2024 05:00
rmunn
rmunn approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@psh0078 psh0078 merged commit 63bdfb3 into develop Jul 3, 2024
9 checks passed
@myieye myieye deleted the feat/check-translation-update branch January 14, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmunn rmunn rmunn approved these changes

Assignees

@psh0078 psh0078

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write code to programmatically check if our translations are up-to-date
2 participants
@psh0078 @rmunn