-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI to choose an org when creating a project #909
Conversation
C# Unit Tests52 tests 52 ✅ 5s ⏱️ Results for commit 24a2359. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start, but the backend also needs to be implemented.
frontend/src/routes/(authenticated)/project/create/+page.svelte
Outdated
Show resolved
Hide resolved
frontend/src/routes/(authenticated)/project/create/+page.svelte
Outdated
Show resolved
Hide resolved
frontend/src/routes/(authenticated)/project/create/+page.svelte
Outdated
Show resolved
Hide resolved
|
Admin should be able to create projects.
|
3f7ccf4
to
c339113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good, some minor change still. Have you tested out the email workflow for draft projects?
I was able to receive a project request email and create the project as admin through the link provided in the email. |
…y=null which would be considered the string null on the other end. We're now filtering out null values before converting to URLSearchParams. This was causing Create project from draft to fail for projects created without an org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just change the title of the null org option and it can be merged in.
In addition I've pushed 2 changes, one was to remove the duplicate OwningOrgId
property on CreateProjectInput
not sure how I missed that before. The second was to fix an obscure bug when a user requests a project without selecting an org, the admin would get an error on the create page due to how null was being converted into the query string. I opted to fix it at a low level.
Feature: Organization Selection for Project Creation
This PR implements the ability to choose an organization when creating a new project. By default, the first organization the user belongs to will be selected.