Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI to choose an org when creating a project #909

Merged
merged 19 commits into from
Jul 8, 2024

Conversation

psh0078
Copy link
Collaborator

@psh0078 psh0078 commented Jul 2, 2024

Feature: Organization Selection for Project Creation

This PR implements the ability to choose an organization when creating a new project. By default, the first organization the user belongs to will be selected.

@psh0078 psh0078 self-assigned this Jul 2, 2024
@psh0078 psh0078 linked an issue Jul 2, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 2, 2024

UI unit Tests

11 tests  ±0   11 ✅ ±0   0s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 24a2359. ± Comparison against base commit 63bdfb3.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 2, 2024

C# Unit Tests

52 tests   52 ✅  5s ⏱️
10 suites   0 💤
 1 files     0 ❌

Results for commit 24a2359.

♻️ This comment has been updated with latest results.

@psh0078 psh0078 requested a review from hahn-kev July 2, 2024 06:36
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start, but the backend also needs to be implemented.

@psh0078
Copy link
Collaborator Author

psh0078 commented Jul 3, 2024

  • If the user is not a member of any organizations, the org option should say that they cannot choose org or something like "You are not part of any organizations".
  • When an admin who is not a member of the organization selected for the project attempts to create it, an error occurs. If this behavior is intentional, we should inform them that they cannot create the project because they are not a member of the selected organization.

@psh0078
Copy link
Collaborator Author

psh0078 commented Jul 3, 2024

Admin should be able to create projects.

  • Pass orgs instead of myOrgs if admin
  • Admins can create projects in two different scenarios: creating requested projects and creating regular projects. In the case of requested projects, the organization selected by the requester should be shown. However, when creating a regular project, no organizations should be selected by default to allow the admin to choose freely.

@psh0078 psh0078 force-pushed the feat/choose-org-when-creating-project branch from 3f7ccf4 to c339113 Compare July 3, 2024 09:04
@psh0078 psh0078 requested a review from hahn-kev July 4, 2024 02:16
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good, some minor change still. Have you tested out the email workflow for draft projects?

@psh0078
Copy link
Collaborator Author

psh0078 commented Jul 4, 2024

it looks good, some minor change still. Have you tested out the email workflow for draft projects?

I was able to receive a project request email and create the project as admin through the link provided in the email.

@psh0078 psh0078 requested a review from hahn-kev July 4, 2024 07:16
hahn-kev added 2 commits July 5, 2024 16:00
…y=null which would be considered the string null on the other end. We're now filtering out null values before converting to URLSearchParams.

This was causing Create project from draft to fail for projects created without an org.
Copy link
Collaborator

@hahn-kev hahn-kev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just change the title of the null org option and it can be merged in.

In addition I've pushed 2 changes, one was to remove the duplicate OwningOrgId property on CreateProjectInput not sure how I missed that before. The second was to fix an obscure bug when a user requests a project without selecting an org, the admin would get an error on the create page due to how null was being converted into the query string. I opted to fix it at a low level.

@psh0078 psh0078 merged commit fd8bc36 into develop Jul 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI to chose an org when creating a project
2 participants