update CommonServiceLocator to remove Microsoft.NETCore.App dependancy

[hahn-kev]

closes sillsdev/languageforge-lexbox#964

LCM references CommonServiceLocator, which in turn references Microsoft.NETCore.App

this breaks various applications when attempting to include LCM. This PR updates that dependancy.

I also did a bit of refactoring to remove references to IServiceLocator in favor of the BCL interface IServiceProvider. I then provided some extension methods so there is source compatibility with this new version. If this is too big of a change and impacts FieldWorks too much then I can remove it and just upgrade the package. However the namespace that IServiceLocator is in has changed as part of the version change, so this seemed like a good time to remove our usage of this interface as it's non standard.

---

This change is 

[jasonleenaylor]

I need to build locally and verify this with FieldWorks, but it looks promising.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @hahn-kev)

---

tests/SIL.LCModel.Tests/DomainImpl/NotebookTests.cs line 5 at r1 (raw file):

// (http://www.gnu.org/licenses/lgpl-2.1.html)

using System;

huh?

[hahn-kev]

tests/SIL.LCModel.Tests/DomainImpl/NotebookTests.cs line 5 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

huh?

IServiceProvider is declared in the system namespace.

[jasonleenaylor]

@hahn-kev here is an issue for FieldWorks we still need to work out
fw\Src\LexText\LexTextControls\LiftMergerSupportCodeAndClasses.cs(4227,38): error CS1061: 'ILcmServiceLocator' does not contain a definition for 'GetAllInstances' and no accessible extension method 'GetAllInstances' accepting a first argument of type 'ILcmServiceLocator' could be found (are you missing a using directive or an assembly reference?) [C:\Repositories\fwroot\fw\Src\LexText\LexTextControls\LexTextControls.csproj]

[hahn-kev]

@jasonleenaylor I added in a drop in, however the IServiceProvider interface is more narrow and there's just a single code path for fetching services and you're expected to just request an IEnumerable<T> where as the Structure map IoC container has very different code paths so I couldn't do the same thing and put a special case when it's our structure map container.

[jasonleenaylor]

Next in line:
fw\Src\LCMBrowser\LCMBrowserForm.Designer.cs(30,29): error CS1061: 'ILcmServiceLocator' does not contain a definition for 'GetInstance' and no accessible extension method 'GetInstance' accepting a first argument of type 'ILcmServiceLocator' could be found (are you missing a using directive or an assembly reference?) [C:\Repositories\fwroot\fw\Src\LCMBrowser\LCMBrowser.csproj]

[hahn-kev]

Next in line: fw\Src\LCMBrowser\LCMBrowserForm.Designer.cs(30,29): error CS1061: 'ILcmServiceLocator' does not contain a definition for 'GetInstance' and no accessible extension method 'GetInstance' accepting a first argument of type 'ILcmServiceLocator' could be found (are you missing a using directive or an assembly reference?) [C:\Repositories\fwroot\fw\Src\LCMBrowser\LCMBrowser.csproj]

I think that one will just need a using statement. Though we could also just add the methods to the ILcmServiceLocator interface instead of using Extension methods. Not sure the best path forward there.

[jasonleenaylor]

With minor changes I got FieldWorks to build with all tests passing. A smoke test showed things apparently working.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @hahn-kev)

[jasonleenaylor]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @hahn-kev)