Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LT-21586: Export/import Phonology #307

Merged
merged 20 commits into from
Jul 31, 2024
Merged

LT-21586: Export/import Phonology #307

merged 20 commits into from
Jul 31, 2024

Conversation

jtmaxwell3
Copy link
Contributor

@jtmaxwell3 jtmaxwell3 commented Jul 30, 2024

Adds PhonologyServices to import and export phonologies.


This change is Reviewable

Copy link

github-actions bot commented Jul 30, 2024

LCM Tests

    8 files  ±0      8 suites  ±0   1m 35s ⏱️ -2s
2 813 tests +3  2 793 ✅ +3  20 💤 ±0  0 ❌ ±0 
5 626 runs  +6  5 549 ✅ +6  77 💤 ±0  0 ❌ ±0 

Results for commit 696255b. ± Comparison against base commit 73e1f66.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor merged commit ebdc736 into master Jul 31, 2024
5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21586 branch July 31, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants