Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21870 and LT-21872 and boundary markers #311

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

jtmaxwell3
Copy link
Contributor

@jtmaxwell3 jtmaxwell3 commented Aug 23, 2024

Fixes LT-21870 (Import phonology - the given key was not present in the dictionary) by not writing out morphological conditions of phonological rules.
Fixes LT-21872 (Import Phonology crashes in Grammar area) by not deleting the PhonemeSet.
Fixes boundary marker problem reported by Ken by not deleting boundary markers in the PhonemeSet.


This change is Reviewable

Copy link

github-actions bot commented Aug 23, 2024

LCM Tests

    8 files  ±0      8 suites  ±0   1m 33s ⏱️ -1s
2 813 tests ±0  2 793 ✅ ±0  20 💤 ±0  0 ❌ ±0 
5 626 runs  ±0  5 549 ✅ ±0  77 💤 ±0  0 ❌ ±0 

Results for commit fb465e1. ± Comparison against base commit 81f2eae.

♻️ This comment has been updated with latest results.

@jasonleenaylor
Copy link
Contributor

tests/SIL.LCModel.FixData.Tests/TestData/HomographDrops/Test.bak line 1 at r1 (raw file):

<?xml version="1.0" encoding="utf-8"?>

I think this was added by mistake.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to add a test project into the repository and add a specific use of your 'TestProjects' method to verify it.

Reviewed 3 of 7 files at r1.
Reviewable status: 3 of 7 files reviewed, all discussions resolved


tests/SIL.LCModel.Tests/DomainServices/PhonologyServicesTest.cs line 1248 at r1 (raw file):

		public void TestPCProjects()
		{
			TestProjects("C:\\Users\\PC\\source\\repos\\FieldWorks\\DistFiles\\Projects");

I'd rather keep this out of the repository even though it is convenient for your testing.

@jtmaxwell3
Copy link
Contributor Author

Where would you like the test project stored?

What is a safe project to add? The FieldWorks repository is public.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 7 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor merged commit aa682dd into master Aug 26, 2024
5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21872 branch August 26, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants