Fix LT-21870 and LT-21872 and boundary markers #311
Conversation
|
I think this was added by mistake. |
There was a problem hiding this comment.
I think it would be good to add a test project into the repository and add a specific use of your 'TestProjects' method to verify it.
Reviewed 3 of 7 files at r1.
Reviewable status: 3 of 7 files reviewed, all discussions resolved
tests/SIL.LCModel.Tests/DomainServices/PhonologyServicesTest.cs line 1248 at r1 (raw file):
public void TestPCProjects() { TestProjects("C:\\Users\\PC\\source\\repos\\FieldWorks\\DistFiles\\Projects");
I'd rather keep this out of the repository even though it is convenient for your testing.
|
Where would you like the test project stored? What is a safe project to add? The FieldWorks repository is public. |
There was a problem hiding this comment.
Reviewed 2 of 7 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
Fixes LT-21870 (Import phonology - the given key was not present in the dictionary) by not writing out morphological conditions of phonological rules.
Fixes LT-21872 (Import Phonology crashes in Grammar area) by not deleting the PhonemeSet.
Fixes boundary marker problem reported by Ken by not deleting boundary markers in the PhonemeSet.
This change is