Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LT-21895: Add test projects to PhonologyServices #312

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

jtmaxwell3
Copy link
Contributor

@jtmaxwell3 jtmaxwell3 commented Aug 30, 2024

This change is Reviewable

Copy link

github-actions bot commented Aug 30, 2024

LCM Tests

    16 files  ±0      16 suites  ±0   2m 49s ⏱️ -1s
 2 827 tests +1   2 807 ✅ +1   20 💤 ±0  0 ❌ ±0 
11 256 runs  +4  11 077 ✅ +4  179 💤 ±0  0 ❌ ±0 

Results for commit 98884e0. ± Comparison against base commit c3b1d64.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 14 files at r1, all commit messages.
Reviewable status: 2 of 14 files reviewed, all discussions resolved


tests/SIL.LCModel.Tests/DomainServices/TestData/PhonologyProjects/project1/SharedSettings/LexiconSettings.plsx line 1 at r1 (raw file):

<?xml version="1.0"?>

All the files except the .fwdata can be excluded from the commit. They may get generated on loading the project into lcm but they don't need to be in the repository

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 14 files at r1, 12 of 12 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)

@jasonleenaylor jasonleenaylor merged commit 7e39678 into master Sep 3, 2024
5 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-21895 branch September 3, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants