Skip to content

Commit

Permalink
Merge pull request #1306 from imnasnainaec/dictionary-services-lift-t…
Browse files Browse the repository at this point in the history
…ypos

Fix typos in SIL.DictionaryServices/Lift/
  • Loading branch information
tombogle authored Dec 7, 2023
2 parents 1b8681f + 06952b7 commit bf62a58
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 11 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Changed

- [SIL.DictionaryServices] Renamed parameter of LiftWriter.WriteHeader from headerConentsNotIncludingHeaderElement to headerContentsNotIncludingHeaderElement
- [SIL.WritingSystems] Updated langtags.json and ianaSubtagRegistry.txt
- [SIL.Core] Enhanced ErrorReport.GetOperatingSystemLabel method to report Windows 11+ and list the version as well.
- [SIL.Core] Enhanced RetryUtility.Retry methods to optionally improve debugging messages, and fixed existing RobustFile and RobustIO methods to use the new optional debugging parameter
Expand Down
10 changes: 5 additions & 5 deletions SIL.DictionaryServices/Lift/HtmlArticleMaker.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Palaso.DictionaryServices.Lift
public class HtmlArticleMaker
{
private readonly XslCompiledTransform _transformer;
private readonly XsltArgumentList _tranformArguments;
private readonly XsltArgumentList _transformArguments;

public HtmlArticleMaker(string pathToWritingSystemPrefs, string pathToPartsOfSpeech)
{
Expand All @@ -33,11 +33,11 @@ public HtmlArticleMaker(string pathToWritingSystemPrefs, string pathToPartsOfSpe
stream.Close();
}

_tranformArguments = new XsltArgumentList();
_tranformArguments.AddParam("writing-system-info-file",
_transformArguments = new XsltArgumentList();
_transformArguments.AddParam("writing-system-info-file",
string.Empty,
pathToWritingSystemPrefs);
_tranformArguments.AddParam("grammatical-info-optionslist-file",
_transformArguments.AddParam("grammatical-info-optionslist-file",
string.Empty,
pathToPartsOfSpeech);
}
Expand All @@ -58,7 +58,7 @@ public string GetHtmlFragment(string entryXml)
StringBuilder builder = new StringBuilder();
using (XmlWriter writer = XmlWriter.Create(builder)) // Don't forget to use CanonicalXmlSettings CP 2011-01
{
_transformer.Transform(reader, _tranformArguments, writer);
_transformer.Transform(reader, _transformArguments, writer);
return builder.ToString();
}
}
Expand Down
12 changes: 6 additions & 6 deletions SIL.DictionaryServices/Lift/LiftWriter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ private void Start()
// _writer.WriteAttributeString("xmlns", "flex", null, "http://fieldworks.sil.org");
}

public void WriteHeader(string headerConentsNotIncludingHeaderElement)
public void WriteHeader(string headerContentsNotIncludingHeaderElement)
{
Writer.WriteStartElement("header");
Writer.WriteRaw(headerConentsNotIncludingHeaderElement);
Writer.WriteRaw(headerContentsNotIncludingHeaderElement);
Writer.WriteEndElement();
}

Expand Down Expand Up @@ -194,10 +194,10 @@ private void AddEtymology(LexEtymology etymology)
// ok if no form is given if (!MultiTextBase.IsEmpty(etymology))
// {
Writer.WriteStartElement("etymology");
//type is required, so add the attribute even if it's emtpy
//type is required, so add the attribute even if it's empty
Writer.WriteAttributeString("type", etymology.Type.Trim());

//source is required, so add the attribute even if it's emtpy
//source is required, so add the attribute even if it's empty
Writer.WriteAttributeString("source", etymology.Source.Trim());
AddMultitextGlosses(string.Empty, etymology.Gloss);
WriteCustomMultiTextField("comment", etymology.Comment);
Expand Down Expand Up @@ -244,7 +244,7 @@ public void AddReversal(LexReversal reversal)
}

/// <summary>
/// in the plift subclass, we add a pronounciation if we have an audio writing system alternative on the lexical unit
/// in the plift subclass, we add a pronunciation if we have an audio writing system alternative on the lexical unit
/// </summary>
protected virtual void InsertPronunciationIfNeeded(LexEntry entry, List<string> propertiesAlreadyOutput)
{
Expand Down Expand Up @@ -379,7 +379,7 @@ private void WriteWellKnownCustomMultiText(PalasoDataObject item,
}

/// <summary>
/// this base implementationg is for when we're just exporting to lift, and dont' want to filter or order.
/// this base implementation is for when we're just exporting to lift, and don't want to filter or order.
/// It is overridden in a child class for writing presentation-ready lift, when
/// we do want to filter and order
/// </summary>
Expand Down

0 comments on commit bf62a58

Please sign in to comment.