-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved unit tests to eliminate spurious failures #1365
Improved unit tests to eliminate spurious failures #1365
Conversation
…Events and actual mouse positions and timing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tombogle)
SIL.Windows.Forms.Tests/Miscellaneous/PortableClipboardTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)
SIL.Windows.Forms.Tests/Miscellaneous/PortableClipboardTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @josephmyers from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @tombogle from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tombogle)
He is not available and his concern was addressed.
These tests formerly relied on clipboard access or Application.DoEvents and actual mouse positions and timing.
This change is