Updated most libraries to latest versions #193
Conversation
Lots of minor refactoring and code cleanup. Fixed AppSmokeTests that have been failing for years. Replaced work-around in FileType to deal with circulardependency error in autofac with use of Lazy<Func<... Moved control instantiation and initialization into designer file for PersonContributionEditor
… with failing ElementGrid tests # Conflicts: # SayMore.sln.DotSettings # src/SayMore/Model/Session.cs # src/SayMore/Model/SessionContribution.cs # src/SayMore/UI/ComponentEditors/PersonContributionEditor.cs # src/SayMoreTests/model/SessionTests.cs
… of SILReleaseTasksProps to happen after installation of the package
…sure the package is present when setting those up
|
I believe all the coding changes are done. Still a draft, pending release of libpalaso, so we can update to use an official release version. |
There was a problem hiding this comment.
Reviewed 84 of 86 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)
src/SayMore/UI/ComponentEditors/ContributorsEditor.cs line 68 at r2 (raw file):
SetComponentFile(file); if (personInformant != null)
Was this removal of a null check supposed to get an elvis operator?
|
Previously, andrew-polk wrote…
No, because it already cannot be null. It is used several lines about with no null check. |
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @tombogle)
src/SayMore/UI/ComponentEditors/ContributorsEditor.cs line 68 at r2 (raw file):
Previously, tombogle (Tom Bogle) wrote…
No, because it already cannot be null. It is used several lines about with no null check.
Hm. Thought I had looked for that, but apparently I missed it.
This especially addresses some issues with archiving as well as a vulnerability in System.Text.Json
This change is