Issue 494: Add deduplication logic to extract_xri script #518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds duplication detection and deduplication logic to the script motivated by this requirement from comment #494 (comment):
Duplicate entries are identified and logged at error level and the script removes duplicates, choosing the match that has target sentence closest in length to the source sentence.
Example tsv:
Note that there's two pairs of duplicates:
This leads to logs:
4 is closer in length, so it's chosen over 3.
0 and 1 tie, so 0 is chosen as it's earlier.
I deliberately made the duplicates non-contiguous to show that contiguity (?) is not required.
Note that id's 5 and 6 aren't duplicates because of case sensitivity. I wasn't sure if case sensitivity is a concept that generalizes well across all languages in a way that's well defined. So I kept the logic case sensitive.
This change is