Issue 494: Add normalization to shrink consecutive whitespace to a single space #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
issue-494-add-file-IO-for-normalize-script
to
master
October 10, 2024 07:57
…ngle space character
rminsil
force-pushed
the
issue-494-shrink-consecutive-spaces-to-single-space
branch
from
1cd44ff
to
c9b3f7d
Compare
rminsil
deleted the
issue-494-shrink-consecutive-spaces-to-single-space
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds very basic normalization for extract strings to shrink consecutive whitespace characters to a single space, e.g.
"a b \t\t c"->"a b c".It addresses this requirement from Michael: (see #494 (comment)):
Note this goes a little further and will pick up any whitespace (tabs, carriage returns, bells) and convert it to a regular space character. I haven't seen cases of this yet - just being cautious.
The only remaining requirement for issue 494 will be:
then issue 494 can be closed. Future requirements would go onto a different issue. I am waiting for a definition of what is considered "punctuation" before implementing this one.
Note this PR is built off #549 and will need to be rebased once 549 is merged.
This change is