SF-3136 Upgrade to Quill v2

[siltomato]

https://slab.com/blog/announcing-quill-2-0/
https://github.com/slab/quill/releases/tag/v2.0.0

Quill v1.3.7 (our current version) was released in September 2019, and it appears that all ongoing work, including bug fixes, is in the v2 branch.

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 88.27160% with 19 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (2191d63) to head (0f939b6).
Report is 191 commits behind head on master.

Files with missing lines	Patch %	Lines
...e/ClientApp/src/app/shared/text/quill-scripture.ts	85.18%	7 Missing and 1 partial ⚠️
...cripture/ClientApp/src/app/core/models/text-doc.ts	20.00%	4 Missing ⚠️
...re/ClientApp/src/app/shared/text/text.component.ts	91.89%	0 Missing and 3 partials ⚠️
...ntApp/src/app/translate/editor/editor.component.ts	89.47%	1 Missing and 1 partial ⚠️
...e/ClientApp/src/app/shared/text/text-view-model.ts	96.55%	1 Missing ⚠️
...late/editor/editor-draft/editor-draft.component.ts	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
- Coverage   80.91%   80.89%   -0.03%     
==========================================
  Files         533      533              
  Lines       31224    31221       -3     
  Branches     5085     5088       +3     
==========================================
- Hits        25265    25255      -10     
- Misses       5198     5203       +5     
- Partials      761      763       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[josephmyers]

I've been playing around with this for the past hour or so, and I haven't seen any bugs with the upgrade, not even the highlight on restore bug I just fixed. And the code changes are much, much cleaner than I was expecting. Good job!

Reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @siltomato)

---

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/quill-scripture.ts line 729 at r1 (raw file):

        this.quill.scrollingContainer.scrollTop = scrollTop;
        this.quill.focus();
      }, 1);

This appears to still work as before, without all this extra code. Good job simplifying!

---

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/quill-scripture.ts line 39 at r1 (raw file):

    if (typeof op.retain.length === 'number') {
      return op.retain.length;

I'm not seeing any mention of the .length format in their docs, though that may not mean much. It's all { retain: 5 }. Did they add this as a new possibility? How do I get here with a breakpoint?

[siltomato]

Thanks, hopefully it'll be a smooth upgrade.

Reviewable status: 35 of 36 files reviewed, 1 unresolved discussion (waiting on @josephmyers)

---

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/quill-scripture.ts line 39 at r1 (raw file):

Previously, josephmyers wrote…

I'm not seeing any mention of the .length format in their docs, though that may not mean much. It's all { retain: 5 }. Did they add this as a new possibility? How do I get here with a breakpoint?

Good catch. The typescript def for Op threw me off, and I hallucinated a length prop from looking at the docs.

Changed to throw an error if the type of retain is not a number.

[josephmyers]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @siltomato)

---

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/quill-scripture.ts line 854 at r2 (raw file):

        }
      } else if (op.retain != null) {
        curIndex += op.retain as number;

Did you have a reason for changing this? It should use the method you created for retain, so that we maintain consistent behavior:
curIndex += getRetainCount(op);

[siltomato]

Also added null coalesce to 0 in some places for the returned result of getRetainCount.

Reviewable status: 32 of 36 files reviewed, 2 unresolved discussions (waiting on @josephmyers)

---

src/SIL.XForge.Scripture/ClientApp/src/app/shared/text/quill-scripture.ts line 854 at r2 (raw file):

Previously, josephmyers wrote…

Did you have a reason for changing this? It should use the method you created for retain, so that we maintain consistent behavior:
curIndex += getRetainCount(op);

No reason. Just forgot to change it back when I was deciding whether to scrap the function.

[josephmyers]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @siltomato)