Correctly extract hashtag content in links and Page Picker filter (fix …

…#1196)
silverbulletmd · Jan 3, 2025 · b344f02 · b344f02
1 parent df9edc5
commit b344f02
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/plugs/markdown/markdown_render.ts b/plugs/markdown/markdown_render.ts
@@ -15,6 +15,7 @@ import { Fragment, renderHtml, type Tag } from "./html_render.ts";
 import { isLocalPath } from "@silverbulletmd/silverbullet/lib/resolve";
 import type { PageMeta } from "@silverbulletmd/silverbullet/types";
 import * as TagConstants from "../../plugs/index/constants.ts";
+import { extractHashtag } from "../../plug-api/lib/tags.ts";
 
 export type MarkdownRenderOptions = {
   failOnUnknown?: true;
@@ -342,8 +343,8 @@ function render(
         name: "a",
         attrs: {
           class: "hashtag sb-hashtag",
-          "data-tag-name": tagText.replace("#", ""),
-          href: `/${TagConstants.tagPrefix}${tagText.replace("#", "")}`,
+          "data-tag-name": extractHashtag(tagText),
+          href: `/${TagConstants.tagPrefix}${extractHashtag(tagText)}`,
         },
         body: tagText,
       };

diff --git a/web/cm_plugins/widget_util.ts b/web/cm_plugins/widget_util.ts
@@ -1,6 +1,7 @@
 import { parsePageRef } from "@silverbulletmd/silverbullet/lib/page_ref";
 import type { Client } from "../client.ts";
 import { tagPrefix } from "../../plugs/index/constants.ts";
+import { extractHashtag } from "@silverbulletmd/silverbullet/lib/tags";
 
 export function attachWidgetEventHandlers(
   div: HTMLElement,
@@ -45,7 +46,7 @@ export function attachWidgetEventHandlers(
         return;
       }
       client.navigate({
-        page: `${tagPrefix}${el.innerText.slice(1)}`,
+        page: `${tagPrefix}${extractHashtag(el.innerText)}`,
         pos: 0,
       });
     });

diff --git a/web/components/page_navigator.tsx b/web/components/page_navigator.tsx
@@ -6,6 +6,7 @@ import type {
 } from "@codemirror/autocomplete";
 import type { PageMeta } from "../../plug-api/types.ts";
 import { tagRegex as mdTagRegex } from "$common/markdown_parser/constants.ts";
+import { extractHashtag } from "@silverbulletmd/silverbullet/lib/tags";
 
 const tagRegex = new RegExp(mdTagRegex.source, "g");
 
@@ -151,7 +152,7 @@ export function PageNavigator({
           const allTags = phrase.match(tagRegex);
           if (allTags) {
             // Search phrase contains hash tags, let's pre-filter the results based on this
-            const filterTags = allTags.map((t) => t.slice(1));
+            const filterTags = allTags.map((t) => extractHashtag(t));
             options = options.filter((pageMeta) => {
               if (!pageMeta.tags) {
                 return false;