Skip to content

Commit

Permalink
fixtypo in NOTES.txt
Browse files Browse the repository at this point in the history
  • Loading branch information
silverqx committed Jul 7, 2024
1 parent 14d2153 commit 95fc7c5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1525,7 +1525,7 @@ inline constants:
- cmake
- normal behavior is that user can switch between inline and extern constants using the INLINE_CONSTANTS cmake option
- default is to provide/show this INLINE_CONSTANTS cmake option with the default value OFF, so extern constants are enabled by default (Clang <v18 has custom patched logic still)
- ❗ all below is true for Clang <v18, all problems all fixed in Clang v18
- ❗ all below is true for Clang <v18, all problems were fixed in Clang v18
- MinGW clang shared build crashes with inline constants
- so don't show INLINE_CONSTANTS cmake option and value is NOT DEFINED in this case so the default will be used and it's the extern constants
- related issue: https://github.com/llvm/llvm-project/issues/55938
Expand Down

0 comments on commit 95fc7c5

Please sign in to comment.