Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Add autologin token regeneration changes to 5.3 changelog #541

Merged
merged 1 commit into from
Jul 23, 2024
Merged

DOC Add autologin token regeneration changes to 5.3 changelog #541

merged 1 commit into from
Jul 23, 2024

Conversation

Cheddam
Copy link
Member

@Cheddam Cheddam commented Jul 4, 2024 •
edited by GuySartorelli
Loading

Description

Adds details regarding silverstripe/silverstripe-framework#11299 to the 5.3 changelog.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no TODO comments, unrelated rewording/restructuring, or arbitrary changes)
    • Small amounts of additional changes are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • The changes follow our writing style guide
  • Code examples follow our coding conventions
  • CI is green

@Cheddam Cheddam force-pushed the pulls/5/session-token-renewal-configuration branch 2 times, most recently from f3872af to 56bcbd4 Compare July 4, 2024 05:13
@GuySartorelli GuySartorelli mentioned this pull request Jul 8, 2024
Open
2 tasks
@Cheddam Cheddam force-pushed the pulls/5/session-token-renewal-configuration branch 2 times, most recently from 149ccb7 to b088831 Compare July 23, 2024 07:03
GuySartorelli
GuySartorelli requested changes Jul 23, 2024
View reviewed changes
en/08_Changelogs/5.3.0.md Outdated Show resolved Hide resolved
en/08_Changelogs/5.3.0.md Outdated Show resolved Hide resolved
@Cheddam Cheddam force-pushed the pulls/5/session-token-renewal-configuration branch from 9f47caf to 41bbb21 Compare July 23, 2024 22:33
GuySartorelli
GuySartorelli approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit c45bebe into silverstripe:5 Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cheddam @GuySartorelli