Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW Include CMS 6 docs #308

Merged

Conversation

emteknetnz
Copy link
Member

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Optional features section in the preview is empty.
  • userhelp preview gives 404 when swapping to CMS 6 docs

Did you follow the instructions in the readme? Looks like several steps were skipped.

package.json Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/master/cms6 branch 2 times, most recently from e7aa533 to 1c7571b Compare September 5, 2024 02:57
@emteknetnz
Copy link
Member Author

Did you follow the instructions in the readme? Looks like several steps were skipped.

No I didn't, missed those. Have implemented them all now.

userhelp preview gives 404 when swapping to CMS 6 docs

Resolved now

Optional features section in the preview is empty.

Resolved now

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed algolia script was also updated.

@GuySartorelli GuySartorelli merged commit cef939d into silverstripe:master Sep 5, 2024
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/master/cms6 branch September 5, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants